From 99bfee263c2c1e57158533f4f9d17e84c2abb163 Mon Sep 17 00:00:00 2001 From: Maciej Konieczny Date: Fri, 26 May 2017 00:32:03 +0200 Subject: [PATCH] fixed ffmpeg error reporting on Python 3 (#565) I got the following error: /usr/local/lib/python3.5/dist-packages/moviepy/audio/io/ffmpeg_audiowriter.py:91: in write_frames + "\n\n"+ffmpeg_error)) E TypeError: Can't convert 'bytes' object to str implicitly To fix it, I wrapped `ffmpeg_error` in `str()` in `ffmpeg_audiowriter.py`. I also did the same in `ffmpeg_writer.py` but I didn't test the latter. --- moviepy/audio/io/ffmpeg_audiowriter.py | 2 +- moviepy/video/io/ffmpeg_writer.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/moviepy/audio/io/ffmpeg_audiowriter.py b/moviepy/audio/io/ffmpeg_audiowriter.py index a13a92130..4e6ca8b71 100644 --- a/moviepy/audio/io/ffmpeg_audiowriter.py +++ b/moviepy/audio/io/ffmpeg_audiowriter.py @@ -88,7 +88,7 @@ def write_frames(self,frames_array): ffmpeg_error = self.proc.stderr.read() error = (str(err)+ ("\n\nMoviePy error: FFMPEG encountered " "the following error while writing file %s:"%self.filename - + "\n\n"+ffmpeg_error)) + + "\n\n" + str(ffmpeg_error))) if b"Unknown encoder" in ffmpeg_error: diff --git a/moviepy/video/io/ffmpeg_writer.py b/moviepy/video/io/ffmpeg_writer.py index 54bcc8e99..9200905f1 100644 --- a/moviepy/video/io/ffmpeg_writer.py +++ b/moviepy/video/io/ffmpeg_writer.py @@ -138,7 +138,7 @@ def write_frame(self, img_array): _, ffmpeg_error = self.proc.communicate() error = (str(err) + ("\n\nMoviePy error: FFMPEG encountered " "the following error while writing file %s:" - "\n\n %s" % (self.filename, ffmpeg_error))) + "\n\n %s" % (self.filename, str(ffmpeg_error)))) if b"Unknown encoder" in ffmpeg_error: