fix(url): show error if urls dont have protocol and disable test run …

[anusha5695]

Issue:
URL w/o protocol fails to get fired

Fix:
1.Show error message if urls dont begin with http:// or https://
2.Disable save and run buttons if above error occurs

Question	Answer
Bug fix	✔
New feature	✔
Breaking change.	✖
Deprecations	✖
Documentation	✖
Tests added	✖

1. Save and run buttons enabled when no error

2. Save and run buttons disabled when base url has errors with red error message

3. Save and run buttons disabled when scenario url has errors with red error message

Related issues: #461

• Have extracted constants for error messages, regex, titles, etc.
• Created isValidUrl function that uses regex for url starting with "http:// and https://" protocol
• Created common setValidationError and resetValidationError functions that is extensible, so that tomorrow if there are any new validations that have to be added, it' ll work out of the box by just adding the field name. This can also be extracted as a separate framework or helper util

[anusha5695]

Hey @enudler, tagging you here

[enudler]

Hi @anusha5695 thanks again for this great PR
If there is a valid base URL with protocol
the step URL doesn't have to be with protocol

examples

1. baseUrl: http://www.google.com; stepUrl: /test => GOOD

2. baeUrl: empty, stepUrl : http://www.google.com => GOOD

3. baseUrl: http://www.google.com; stepUrl: http://www.google.com/test => GOOD

4. baseUrl: google.com => BAD

5. baseUrl: empty; stepUrl: www.google.com => BAD

6. baseUrl: empty; stepUrl: empty => BAD

[anusha5695]

Oh. Sorry will make changes now. @enudler
Just confirming some scenarios that aren't a bit clear

Base : empty , step: empty - BAD
Base : empty , step: http - GOOD
Base : http, step : empty - GOOD
Base : http , step : http - GOOD
Base : www , step: http - ??
Base : http, step: www - ??
Base: www, step: www - BAD

Would you fill in the question marks alone? Just for clarity?

[enudler]

hi @anusha5695
Base : empty , step: empty - BAD
Base : empty , step: http - GOOD
Base : http, step : empty - GOOD
Base : http , step : http - GOOD
Base : www , step: http - GOOD (step overrides base when protocol used)
Base : http, step: www - GOOD (actually it's bad but I am not sure on an easy way to find this)
Base: www, step: www - BAD

[manorlh]

thanks for your PR:)
The input component is not aligned when an error is showed.
think that need to add height for all input components so when there is an error it will be already aligned

[anusha5695]

@enudler @manorlh
Thanks both of you. 👍 will fix both the issues.

[anusha5695]

hi @enudler fixed the combination of errors according to this:

Base : empty , step: empty - BAD
Base : empty , step: http - GOOD
Base : http, step : empty - GOOD
Base : http , step : http - GOOD
Base : www , step: http - GOOD
Base : http, step: www - GOOD
Base: www, step: www - BAD

---

hi @manorlh, sorry couldn't fix the styling feedback immediately though. hurrying for a vacation. could you open a separate bug card. I ll fix the styling once back?

TIA. :)

[manorlh]

we can wait for it, we want to avoid inserting bugs to master.
thanks

[enudler]

hi @anusha5695
are you able to finish this PR?