Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After Predator starts, check the INTERNAL_ADDRESS is accessible #423

Closed
enudler opened this issue Sep 26, 2020 · 1 comment
Closed

After Predator starts, check the INTERNAL_ADDRESS is accessible #423

enudler opened this issue Sep 26, 2020 · 1 comment
Assignees
@enudler
Labels
1.6.0 backend enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@enudler
Copy link
Collaborator

enudler commented Sep 26, 2020

Is your feature request related to a problem? Please describe.
Predator is spinning up predator-runners using k8s/dcos/docker-engine
Predator passes to its predator-runners 'INTERNAL_ADDRESS' where the runners can reach Predator
If this address is unreachable, tests will fail to start.

Describe the solution you'd like
It would be good to test this address when the Predator service starts.
it should be tested straight away after the app is listening.
I suggest calling 'INTERNAL_ADDRESS' which is usually http://:/v1
by removing /v1 and adding /health
GET http://:/health

If the response is not 200, Predator should not start and throw error explaining the issue.

Some more info about INTERNAL_ADDRESS
https://zooz.github.io/predator/installation.html#docker
@enudler enudler added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers backend Hacktoberfest labels Sep 26, 2020
@enudler enudler mentioned this issue Sep 27, 2020
Merged
@enudler enudler self-assigned this Oct 1, 2020
@enudler
Copy link
Collaborator Author

enudler commented Oct 1, 2020

Merged to master in #430

@enudler enudler closed this as completed Oct 1, 2020
@enudler enudler added the 1.6.0 label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enudler enudler

Labels
1.6.0 backend enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enudler