Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): addding processor_id to tests resource #240

Merged
merged 4 commits into from
Dec 8, 2019

Conversation

enudler
Copy link
Collaborator

@enudler enudler commented Dec 7, 2019

We are missing unit tests for processors module.
I have lowered the coverage threshold to 90% but we need to bump it up before merging feature branch to master.

@enudler enudler requested a review from NivLipetz December 7, 2019 20:17
@enudler
Copy link
Collaborator Author

enudler commented Dec 7, 2019

closes #191

@enudler
Copy link
Collaborator Author

enudler commented Dec 8, 2019

@NivLipetz
Thanks for the review
all issues resolved

@NivLipetz NivLipetz merged commit 8325c58 into customjsphase2 Dec 8, 2019
@enudler enudler deleted the 191-tests-processor-id branch January 26, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants