Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-js): implement POST /processors #213

Merged
merged 18 commits into from
Oct 20, 2019
Merged

feat(custom-js): implement POST /processors #213

merged 18 commits into from
Oct 20, 2019

Conversation

NivLipetz
Copy link
Member

@NivLipetz NivLipetz commented Oct 11, 2019 •
edited
Loading

closes #192
closes #189

@NivLipetz NivLipetz changed the title feat(custom-js): implement POST /processors WIP: feat(custom-js): implement POST /processors Oct 11, 2019
@NivLipetz NivLipetz force-pushed the post-processor branch 2 times, most recently from 8ca95eb to d196f09 Compare October 12, 2019 08:27
@NivLipetz NivLipetz force-pushed the customjsphase2 branch 2 times, most recently from b0be1c9 to 2b94e6b Compare October 12, 2019 08:49
@NivLipetz NivLipetz force-pushed the post-processor branch 2 times, most recently from fc35b13 to 27c5a30 Compare October 12, 2019 09:11
@syncush
Copy link
Collaborator

syncush commented Oct 12, 2019

when the PR is accepted, integration tests can be added to #212

@NivLipetz NivLipetz requested a review from enudler October 15, 2019 20:43
enudler
enudler approved these changes Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@enudler enudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add validation that the javascript downloaded is 'legit'

@NivLipetz
Copy link
Member Author

I would add validation that the javascript downloaded is 'legit'

sounds good, and this addition will close issue #192

NivLipetz and others added 11 commits October 20, 2019 13:52
@enudler enudler merged commit 64510d5 into customjsphase2 Oct 20, 2019
NivLipetz added a commit that referenced this pull request Nov 9, 2019
@NivLipetz
WIP: feat(custom-js): implement POST /processors (#213)
72cce5d 
* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test
@NivLipetz NivLipetz changed the title WIP: feat(custom-js): implement POST /processors feat(custom-js): implement POST /processors Nov 9, 2019
NivLipetz added a commit that referenced this pull request Nov 9, 2019
@NivLipetz
WIP: feat(custom-js): implement POST /processors (#213)
28cfe7d 
* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test
NivLipetz added a commit that referenced this pull request Nov 9, 2019
@NivLipetz
feat(custom-js): implement GET /processors/{processor_id} (#230)
6dd9497 
* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors/{processor_id}

* test(custom-js): add tests for GET /processors/{processor_id}
NivLipetz pushed a commit that referenced this pull request Nov 10, 2019
@syncush @NivLipetz
feat(custom-js): implement DELETE /processors/{processor_id} (#231)
00850cd 
* feat(api): add api spec for processors resource

closes #185

fix #185

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors (#212)

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor

* feat(custom-js): implement DELETE /processors/{processor_id}

* feat(custom-js): implement DELETE /processors/{processor_id}
NivLipetz added a commit that referenced this pull request Nov 20, 2019
@NivLipetz
WIP: feat(custom-js): implement POST /processors (#213)
6d925df 
* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test
NivLipetz added a commit that referenced this pull request Nov 20, 2019
@NivLipetz
feat(custom-js): implement GET /processors/{processor_id} (#230)
0394723 
* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors/{processor_id}

* test(custom-js): add tests for GET /processors/{processor_id}
NivLipetz pushed a commit that referenced this pull request Nov 20, 2019
@syncush @NivLipetz
feat(custom-js): implement DELETE /processors/{processor_id} (#231)
8b2d9d0 
* feat(api): add api spec for processors resource

closes #185

fix #185

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* WIP: feat(custom-js): implement POST /processors (#213)

* docs(image): fix outdated image in docs (#214)

* chore(ci/cd): remove circleci docker_layer_caching (#218)

* feat(api): add api spec for processors resource (#200)

* feat(api): add api spec for processors resource

* feat(api): add api spec for processors resource

closes #185

fix #185

* fix(typo): typo date_time to date-time

* fix(typo): typo date_time to date-time

* chore(openapi3): code review comments addressed

* docs(api): add download endpoint for processor files

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* chore: fix rebase to master

* feat(custom-js): implement POST /processors

* test(processors): add tests for POST /processors (#217)

* test(processors): add tests for POST /processors

* style(processors): fix processors cassandra connector name

* feat(processors): add js validation on POST /processors

* fix(processors): add updated_at/created_at to processors resource

* test(processors): add validateJavascriptContent unit-tests

* test(create-test): fix processor file download error message in test

* feat(custom-js): implement GET /processors (#212)

* chore(dependencies): update cassandra-driver to v4.1.0 (#210)

* feat(custom-js): implement GET /processors (Sequelize only)

* test(processors): add tests for GET /processors (#186)

* feat(custom-js): implement GET /processors (cassandra)

* test(processors): add unit-tests for insertProcessor

* feat(custom-js): implement DELETE /processors/{processor_id}

* feat(custom-js): implement DELETE /processors/{processor_id}
@enudler enudler deleted the post-processor branch January 26, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enudler enudler enudler approved these changes

@syncush syncush syncush left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NivLipetz @syncush @enudler