2024-10-23-r1

[Zoey2936]

Breaking changes in last release, please read the last changelog here: https://github.com/ZoeyVid/NPMplus/releases/tag/2024-10-21-r1

What's Changed

• doc updates
• dep updates
• merge Update launch.sh to fix goaccess data storage #1182 by @Sproglet (keep goaccess data after rotating logs)
• run ocsp script before testing nginx config
• fix updates from older versions
• remove useless headers
• move some files
• change chipper order

How to update

• Read the changes above
• Pull the zoeyvid/npmplus:latest image
• apply possible changes that maybe effect you from above to your compose.yaml/NPMplus
• redeploy the compose stack
• report any issues you find

Full Changelog: 2024-10-22-r1...2024-10-23-r1

---

This discussion was created from the release 2024-10-23-r1.

[gadget78]

if you "do not" set the ACME_EMAIL in the compose.yml file (and instead you # it out)
then when 1st run you get a error about reading the certbot.ini file...

-------------------------------------
 _ _  ___  __ __       _
| \ || . \|  \  \ ___ | | _ _  ___
|   ||  _/|     || . \| || | |[_-[
|_\_||_|  |_|_|_||  _/|_| \__|/__/
                 |_|
-------------------------------------
Version:  2.12.1+5b65de0
Date:     Thu Oct 24 20:57:59 BST 2024
User:     root
PUID:     0
User ID:  0
PGID:     0
Group ID: 0
-------------------------------------

usage: 
  certbot [SUBCOMMAND] [options] [-d DOMAIN] [-d DOMAIN] ...

Certbot can obtain and install HTTPS/TLS/SSL certificates.  By default,
it will attempt to use a webserver both for obtaining and installing the
certificate. 
certbot: error: Unable to open config file: /etc/tls/certbot.ini. Error: No such file or directory

if i alter the launch.sh file (lines 56, 61, and 66) for eg...

NPMplus/rootfs/usr/local/bin/launch.sh

Line 56 in 7a2799b

if ! certbot --logs-dir /tmp/certbot-log --work-dir /tmp/certbot-work --config-dir /data/tls/certbot --config /etc/tls/certbot.ini --agree-tos --non-interactive --no-eff-email \

and edit --config /etc/tls/certbot.ini to --config /etc/certbot.ini

it then works :)

[gadget78]

excellent, will give that a try...
ive also found another issue, althou i "think" it may of been intentional, but im not able to find the "fix"/"new method"

when using the API to create a access token, i use "expiry", to create a token i can then use longer than 24hours...
but when trying to use expiry within the token request i get
{"error":{"code":400,"message":"data must NOT have additional properties"}}

so when i use
curl -k -s -m 10 "https://<IP>:81/api/tokens" -H "Content-Type: application/json; charset=UTF-8" --data-raw "{\"identity\":\"<EMAIL>\",\"secret\":\"<PASSWORD>\",\"expiry\":\"1y\"}"
is there a new endpoint ? or another way to add expiry ?
i see within token.js does still have expiry functions in getFreshToken but im not sure how we can access this via the tokens API endpoint ? ..

[Zoey2936]

This because of an upstream change:
how it was before:
https://github.com/NginxProxyManager/nginx-proxy-manager/blob/v2.11.3/backend/schema/endpoints/tokens.json
and after:
https://github.com/ZoeyVid/NPMplus/blob/develop/backend/schema/paths/tokens/post.json
as you see expiry was removed

[Zoey2936]

But you could try to change additionalProperties to true in /app/schema/paths/tokens/post.json (inside the container), then restart npmplus (not recreate) and then tets it and report back

[gadget78]

yep, changing additionalProperties to true in /app/schema/paths/tokens/post.json DOES get it working :)

[Zoey2936]

should be fixed in develop