Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamsObj causing circular object JSON error #159

Closed
deandavison2 opened this issue Aug 27, 2015 · 5 comments
Closed

ParamsObj causing circular object JSON error #159

deandavison2 opened this issue Aug 27, 2015 · 5 comments
Labels
bug
Milestone
Version 0.5.9

Comments

@deandavison2
Copy link
Contributor

No problems with 0.5.5, but if I jump to 0.5.8, I get this error
TypeError: Converting circular structure to JSON

It seems paramsObj is now giving an object with a circular structure where it was not before. It is including my filters object in it automatically now, breaking things.
@deandavison2
Copy link
Contributor Author

I could change a whole bunch of code in order to support the change but please update changelog to reflect this breaking change.

@Zizzamia
Copy link
Owner

Zizzamia commented Sep 3, 2015

ThankYou for the hands up, the paramsObj missed filters object and was causing problem for the server-side version.
Do you want update the CHANGELOG please?

@Zizzamia Zizzamia added the bug label Sep 3, 2015
@Zizzamia Zizzamia added this to the Version 0.5.9 milestone Sep 3, 2015
@deandavison2
Copy link
Contributor Author

Opened pull request for CHANGELOG update. Pull Request

@Zizzamia
Copy link
Owner

That's awesome! ThankYou so much

@Zizzamia
Copy link
Owner

Also just release on bower the version 0.5.9 with this fix in it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 0.5.9
Development

No branches or pull requests
2 participants
@Zizzamia @deandavison2