Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature in/out Edges convenience functions #357

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Sep 28, 2023

Add outEdges and inOutEdges functions, that return sets of edges linked to a node (issue #310).

  • outEdges returns the DirectedEdges coming out of a node
  • inOutEdges returns all the edges contaning a node

@github-actions github-actions bot added test Something about test core something about core labels Sep 28, 2023
@ghost
Copy link

ghost commented Sep 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #357 (84bfeb6) into master (31ac919) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 96.20%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   97.48%   97.44%   -0.04%     
==========================================
  Files          55       55              
  Lines        8745     8961     +216     
==========================================
+ Hits         8525     8732     +207     
- Misses        220      229       +9     
Flag Coverage Δ
unittests 97.44% <96.20%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/CXXGraph/Graph/Graph.hpp 95.57% <100.00%> (+0.06%) ⬆️
test/GraphTest.cpp 98.99% <95.67%> (-0.87%) ⬇️

... and 1 file with indirect coverage changes

@sbaldu
Copy link
Collaborator Author

sbaldu commented Sep 28, 2023

I'll try to increase coverage

@ZigRazor
Copy link
Owner

I'll try to increase coverage

Ok, I wait your commit to merge

@sbaldu
Copy link
Collaborator Author

sbaldu commented Sep 28, 2023

@ZigRazor Ok I've added a few checks. I think you can merge now.

@ZigRazor ZigRazor merged commit 4a74dcc into ZigRazor:master Sep 28, 2023
24 of 27 checks passed
@sbaldu sbaldu deleted the feature_inout_edges branch October 9, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add convenience functions for computing out neighbor nodes, inout neighbor nodes
2 participants