Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature getters for set of neighbors #318

Merged
merged 36 commits into from
Jun 5, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Jun 1, 2023

Write functions that return the set for neighbors for a node (issue #310 ).

  • outNeighbors returns the set of nodes linked to the node with out-going directed edges
  • inOutNeighbors returns the set of nodes linked to the node with any type of edge

sbaldu and others added 30 commits May 12, 2023 15:19
Fix typo in benchmark FloydWarshall
@github-actions github-actions bot added core something about core test Something about test labels Jun 1, 2023
@sbaldu sbaldu requested a review from nrkramer June 1, 2023 09:02
@ghost
Copy link

ghost commented Jun 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #318 (adeb13f) into master (4569d22) will increase coverage by 0.04%.
The diff coverage is 99.58%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   97.16%   97.21%   +0.04%     
==========================================
  Files          54       54              
  Lines        7587     7793     +206     
==========================================
+ Hits         7372     7576     +204     
- Misses        215      217       +2     
Flag Coverage Δ
unittests 97.21% <99.58%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Graph/Graph.hpp 94.92% <97.67%> (+0.04%) ⬆️
test/GraphTest.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sbaldu sbaldu requested a review from ZigRazor June 1, 2023 10:06
@ZigRazor ZigRazor merged commit 90a9973 into ZigRazor:master Jun 5, 2023
@sbaldu sbaldu deleted the feature_inoutedges_getters branch June 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants