Fix errors causing some tests in PartitionTest to fail. #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to call join() on threads in Partitioner::startCoordinated() C++ will sometimes throw an invalid_argument exception as some of or all of the threads might be default constructed and therefore not joinable. This happens because the threads are only assigned a function if a given condition is met. This PR fixes this by checking if a thread is joinable before calling join() on the thread, which subsequently fixes and passes PartitionTest.test_1, PartitionTest.test_3, PartitionTest.test_5 and PartitionTest.test_7.