Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding library name (CXXGRAPH) in header guards to avoid possible conflicts in include folders Node and Graph #117

Merged
merged 3 commits into from
Oct 17, 2021

Conversation

AlfredCP
Copy link
Contributor

@AlfredCP AlfredCP commented Oct 17, 2021

@github-actions github-actions bot added the core something about core label Oct 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #117 (9824437) into master (dc2e91c) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   96.35%   96.61%   +0.25%     
==========================================
  Files          37       38       +1     
  Lines        3818     4043     +225     
==========================================
+ Hits         3679     3906     +227     
+ Misses        139      137       -2     
Flag Coverage Δ
unittests 96.61% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Edge/DirectedEdge.hpp 100.00% <ø> (ø)
include/Edge/DirectedWeightedEdge.hpp 100.00% <ø> (ø)
include/Edge/Edge.hpp 88.88% <ø> (ø)
include/Edge/UndirectedEdge.hpp 100.00% <ø> (ø)
include/Edge/UndirectedWeightedEdge.hpp 100.00% <ø> (ø)
include/Edge/Weighted.hpp 100.00% <ø> (ø)
include/Graph/Graph.hpp 97.89% <ø> (+0.44%) ⬆️
include/Graph/Graph_TS.hpp 43.47% <ø> (ø)
include/Node/Node.hpp 100.00% <ø> (ø)
include/Partitioning/Partition.hpp 78.94% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2e91c...9824437. Read the comment docs.

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@ZigRazor ZigRazor merged commit 241cf73 into ZigRazor:master Oct 17, 2021
@ZigRazor
Copy link
Owner

@AlfredCP thank you for this PR, if you show interest with other 1 or 2 issue correction, and if you are interested i can invite you to being collaborator of this project!

@AlfredCP
Copy link
Contributor Author

AlfredCP commented Oct 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__EDGE_H__ Header guard can create conflict __NODE_H__ header guard can create conflict
3 participants