Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You will be charged a setup fee" pop-up preventing payment from being receivable if denoted in USD #2754

Closed
makeasnek opened this issue Jan 19, 2025 · 5 comments
Labels
Bug Something isn't working

Comments

@makeasnek
Copy link

Describe the bug

When I go to make a payment request, if it's over my lightning channel capacity, a warning pops up which changed the buttons so "request" doesn't show any more. This only happens when putting in USD amounts

Reproduce

  1. Click "B" icon at bottom of app
  2. Put in a USD amount > your inbound liquidity
  3. "You will be charged a setup fee" pop-up happens
  4. "Request" button now no longer exists. It has been replaced by some specific sat amounts (50k,100k, etc)

ZEUS version

v0.9.4

Node interface

Embedded LND

Network

Clearnet

Device

Android

Device operating system

Android

Log output

@makeasnek makeasnek added the Bug Something isn't working label Jan 19, 2025
@kaloudis
Copy link
Contributor

This is a bit of a challenging one. Hard to determine which presets to use for fiat denominations with both fluctuating exchange rates and all the currencies we support.

If you enter in a fiat amount of the equivalent of 100k sats or more, the presets disappear and the Request button reappears.

Do you have any recommendations as to how to improve this behavior?

@makeasnek
Copy link
Author

makeasnek commented Jan 20, 2025

Not sure I understand the challenge here, it should work like everywhere else in the app when you put in a USD number: it convert it to the amount of sats equivalent at the moment and then makes the invoice/payment/whatever using that amount of sats.

For example, if I go to the main screen -> lightning -> receive, I can put in an amount in USD and click 'create invoice'. That works on the conversion screen too. The problem is that on the conversion screen (as reported in this issue), if the amount is greater than my current lightning channel capacity, the "request" button disappears for some odd reason.

@makeasnek
Copy link
Author

I re-read this issue and realized it may not be clear what I'm talking about here's what happens, as you can see, the request button vanishes but only for sizes over a certain amount

Image

Image

Image

@kaloudis
Copy link
Contributor

@makeasnek here you can press 'Other' and still request the amount denominated in dollars

@makeasnek
Copy link
Author

@kaloudis the problem isn't inputting an amount, it's that the "request" button would disappear. I could put in any amount I want, I just couldn't actually make the invoice. In any case, the latest version has fixed this so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants