Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retcon new sync logic into RFC1 #899

Closed
hdevalence opened this issue Aug 13, 2020 · 2 comments
Closed

Retcon new sync logic into RFC1 #899

hdevalence opened this issue Aug 13, 2020 · 2 comments
Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup C-design Category: Software design work

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Aug 13, 2020 •
edited by teor2345
Loading

The sync logic was fixed up in #887 and now RFC1 doesn't match the implementation. Let's wait a bit to be sure we don't want to make even more changes, then retcon the design into the RFC.

Let's also remove the RFC template text from the RFC. We can:

  • rewrite the RFC content to fit the template, or
  • delete the template text
@hdevalence hdevalence added A-docs Area: Documentation Poll::Pending C-design Category: Software design work C-cleanup Category: This is a cleanup labels Aug 13, 2020
@hdevalence hdevalence self-assigned this Aug 13, 2020
@hdevalence hdevalence mentioned this issue Aug 13, 2020
Closed
44 tasks
@hdevalence hdevalence added S-blocked Status: Blocked on other tasks and removed Poll::Pending labels Aug 17, 2020
@teor2345 teor2345 added this to the Sync and Network milestone Sep 29, 2020
@teor2345 teor2345 mentioned this issue Oct 27, 2020
Closed
@teor2345
Copy link
Contributor

@hdevalence should this task be in the first alpha release?

It seems like something we could leave for later. But it would be nice to do as soon as sync stabilises.

@oxarbitrage oxarbitrage mentioned this issue Oct 27, 2020
Merged
@teor2345 teor2345 removed this from the First Alpha Release milestone Nov 12, 2020
@teor2345 teor2345 removed the S-blocked Status: Blocked on other tasks label Jan 5, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@dconnolly
Copy link
Contributor

Defunct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup C-design Category: Software design work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hdevalence @dconnolly @mpguerra @teor2345