Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to rustfmt format version 2 #3280

Closed
teor2345 opened this issue Dec 22, 2021 · 1 comment
Closed

Switch to rustfmt format version 2 #3280

teor2345 opened this issue Dec 22, 2021 · 1 comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@teor2345
Copy link
Contributor

teor2345 commented Dec 22, 2021 •
edited
Loading

Motivation

rustfmt uses some outdated and confusing rules, such as formatting nested tuple accesses with a space.

If we switch to format version 2, then we'll get slightly better formatting.

Previous changes like this have had unexpected impacts, so I don't want to make this change until we schedule time for cleanups.

Tasks

  • add a zebra/rustfmt.toml containing version = Two
  • run cargo fmt
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Optional labels Dec 22, 2021
@teor2345 teor2345 mentioned this issue Dec 22, 2021
Merged
1 task
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2022

Previous changes like this have had unexpected impacts, so I don't want to make this change until we schedule time for cleanups.

@teor2345 teor2345 closed this as completed Mar 1, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpguerra @teor2345