Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly implement conversion from Vec<NoteCommitment> into NoteCommitmentTree #2462

Closed
jvff opened this issue Jul 8, 2021 · 1 comment
Closed

Possibly implement conversion from Vec<NoteCommitment> into NoteCommitmentTree #2462

jvff opened this issue Jul 8, 2021 · 1 comment
Labels
C-enhancement Category: This is an improvement

Comments

@jvff
Copy link
Contributor

jvff commented Jul 8, 2021

Motivation

The code contained a stub implementation of From<Vec<NoteCommitment>> for NoteCommitmentTree. This was initially added in commit b93abea34, but seems like it's currently unused.

As part of the work for #2369, the code was removed to avoid being used and inadvertently leading to a panic.

A decision should be made whether the conversion should be implemented or not.

Related Work
@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jul 8, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jul 8, 2021 •
edited
Loading

This code is revised or removed in the incremental note commitment tree PR #2407 / ticket #1287, so we don't need a separate ticket for it.

@teor2345 teor2345 closed this as completed Jul 8, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpguerra @jvff @teor2345