Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename proptest-impl feature #2424

Closed
jvff opened this issue Jun 30, 2021 · 0 comments
Closed

Rename proptest-impl feature #2424

jvff opened this issue Jun 30, 2021 · 0 comments
Labels
C-enhancement Category: This is an improvement

Comments

@jvff
Copy link
Contributor

jvff commented Jun 30, 2021 •
edited by teor2345
Loading

Motivation

From what I understood, the feature was initially created to allow proptests to access arbitrary strategies implemented in separate crates. However, the feature has started being used for other test cases, so it's best to make that explicit with a more generic name.

The name is still to be defined.

Suggestions:

  • test-utils
  • test-impl

Note: fastmod ignores hidden files by default. Use fastmod ... .github * instead.
@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jun 30, 2021
@jvff jvff mentioned this issue Jun 30, 2021
Merged
3 tasks
@teor2345 teor2345 added the P-Low label Jul 1, 2021
@teor2345 teor2345 mentioned this issue Nov 15, 2021
Merged
4 tasks
@jvff jvff added S-incomplete and removed S-needs-triage Status: A bug report needs triage labels Feb 24, 2022
@jvff jvff closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvff @teor2345