Generic type parameter being removed while using ConvertToCSharpSource

[eestein]

While using ConvertToCSharpSource on a parameter's type:

parameterInfo.ParameterType.ConvertToCSharpSource(true)

The type parameter is being excluded:

Here's the original code:

Expression<Func<TEntity, bool>> predicate = null

As you can see, TEntity has been removed.

What seems weird is that the Type contains the TEntity reference:

And that the same call to a method's return type includes the type parameter:

method.ReturnType.ConvertToCSharpSource(true)

@ZacharyPatten I'm filing this as a bug, because it seems like so, but please let me know if there's something wrong I'm doing or expecting...

Thanks.

EDIT: just as an extra info (I'm debugging, trying to find out where the problem is), the generic arguments seem to be all there:

[eestein]

@ZacharyPatten Ok, I think I found the problem:

For the first iteration showGenericParameters is true, but for the second one it's false:

ConvertToCSharpSource on line 557 is calling public static string ConvertToCSharpSource(this Type type, bool showGenericParameters = false) not the inner function, you should probably add the showGenericParameters down the chain if that was intentional.

[ZacharyPatten]

Thanks for the info, I was able to replicate the issue. This should be an easy fix.

It may be as simple as changing ConvertToCSharpSource(correctGeneric) to ConvertToCSharpSource(correctGeneric, showGenericParameters) on this line:

Towel/Sources/Towel/Meta.cs

Line 557 in f291d37

: (firstIteration ? string.Empty : " ") + ConvertToCSharpSource(correctGeneric));

But I need to do a bit more testing to validate.

The unit tests are here:

Towel/Tools/Towel_Testing/Meta.cs

Line 16 in f291d37

public void Type_ConvertToCsharpSource()

So I'll be creating a new branch and adding a/some unit tests to cover this topic.

[eestein]

Thanks!
Once you push the fix, is a new version automatically released? Just so I know when to update.

[ZacharyPatten]

Once the fix is ready I will create a release in the GitHub repo. There is a GitHub action that when a release is created on the repo, it will deploy a nuget package. It takes ~5-10 minutes for the nuget package to show up, so give it a few minutes after the release in the repo is created and you should see it in nuget.org and package explorer.

GitHub Action for nuget package deployments: https://github.com/ZacharyPatten/Towel/blob/main/.github/workflows/Towel%20Deployment.yml
Towel Releases: https://github.com/ZacharyPatten/Towel/releases

[eestein]

Thank you! :)

[ZacharyPatten]

@eestein I pushed an update. If the update did not fix your issue we can re-open this issue.

To be honest I can't remember why I decided to make the showGenericParameters parameter false by default. As I'm thinking about it now... most people probably want it true by default. When it is false there can be some odd behaviors like:

Towel/Tools/Towel_Testing/Meta.cs

Line 120 in ab85339

#warning TODO: review this test case

So there is probably additional improvement that can be done to to code.

Regardless, thank you for addressing this issue. :)

[eestein]

I agree it makes sense to keep it true by default, that's how I'm using it anyway :D

Thank you for the quick fix, I've already tested it and it's working!

I just ran into another issue now, but I'm debugging to see if the problem is on my end. I'll open another bug, if necessary.

Thanks again!