Refactor results into common CompilationResult hierarchy #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new sealed `CompilationResult` hierarchy that includes subtypes for JS and JVM results. This should be a mostly source-compatible (but not binary compatible) change. One important source compatibility change is that now JS files output is just called `jsFiles` rather than the borrowed JVM "classesAndResources" name from before.
|
@JakeWharton would be curious for your thoughts on this! |
JakeWharton
approved these changes
Feb 9, 2023
| @@ -0,0 +1,67 @@ | |||
| package com.facebook.buck.jvm.java.javax.com.tschuchort.compiletesting | |||
|
|
||
| /** Result of the compilation. */ | ||
| @ExperimentalCompilerApi | ||
| sealed class CompilationResult( |
There was a problem hiding this comment.
Could be interface. Don't think you gain anything by using a class here except maybe the future pain of the rigidity of inheritance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new sealed
CompilationResulthierarchy that includes subtypes for JS and JVM results. This should be a mostly source-compatible (but not binary compatible) change.One important source compatibility change is that now JS files output is just called
jsFilesrather than the borrowed JVM "classesAndResources" name from before.Resolves #129