Skip to content

Commit

Permalink
[YSQL] 1049 ASAN reported memory leaks in Postgres
Browse files Browse the repository at this point in the history
Summary:
This happens for '\d' command.  This command is commented out from our test for now.
Once it is fixed, we'll add it back to the test.

A bug has been found
#1049

Test Plan: run java::pgsql tests

Reviewers: mikhail

Reviewed By: mikhail

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6370
  • Loading branch information
nocaway committed Mar 21, 2019
1 parent 9eaf15b commit 0f261a9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 5 additions & 9 deletions src/postgres/src/test/regress/expected/yb_bit.out
Original file line number Diff line number Diff line change
Expand Up @@ -556,14 +556,10 @@ CREATE TABLE bit_defaults(
b3 bit varying(5) DEFAULT '1001',
b4 bit varying(5) DEFAULT B'0101'
);
\d bit_defaults
Table "public.bit_defaults"
Column | Type | Collation | Nullable | Default
--------+----------------+-----------+----------+---------------------
b1 | bit(4) | | | '1001'::"bit"
b2 | bit(4) | | | '0101'::"bit"
b3 | bit varying(5) | | | '1001'::bit varying
b4 | bit varying(5) | | | '0101'::"bit"

-- Describing table with default values causes memory leaks in Postgres code.
-- TODO(neil) Add the test case back after the following github is fixed.
-- https://github.com/YugaByte/yugabyte-db/issues/1049
--
-- \d bit_defaults
-- INSERT INTO bit_defaults DEFAULT VALUES;
-- TABLE bit_defaults;
6 changes: 5 additions & 1 deletion src/postgres/src/test/regress/sql/yb_bit.sql
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ CREATE TABLE bit_defaults(
b3 bit varying(5) DEFAULT '1001',
b4 bit varying(5) DEFAULT B'0101'
);
\d bit_defaults
-- Describing table with default values causes memory leaks in Postgres code.
-- TODO(neil) Add the test case back after the following github is fixed.
-- https://github.com/YugaByte/yugabyte-db/issues/1049
--
-- \d bit_defaults
-- INSERT INTO bit_defaults DEFAULT VALUES;
-- TABLE bit_defaults;

0 comments on commit 0f261a9

Please sign in to comment.