Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metabox add-ons tabs shouldn't be link when there's only one enabled #5919

Closed
afercia opened this issue Oct 19, 2016 · 1 comment · Fixed by #12094
Closed

Metabox add-ons tabs shouldn't be link when there's only one enabled #5919

afercia opened this issue Oct 19, 2016 · 1 comment · Fixed by #12094
Assignees
@abotteram
Labels
component: a11y component: metabox

Comments

@afercia
Copy link
Contributor

afercia commented Oct 19, 2016

See Meta box single tabs shouldn't be links #5728

Opening an issue here for discussion and because maybe this would require some way to count the enabled add-ons. I guess specific issues for the add-ons can be opened later on the related repos.

When there's only one add-on enabled, the tab link should not be a link since there are no other tabs to switch to and thus it is not a real tabbed interface:

screen shot 2016-10-19 at 12 13 42

of course when two or more add-ons are enabled, it makes perfectly sense to have links:

screen shot 2016-10-19 at 12 14 00
@afercia afercia self-assigned this Jan 21, 2019
@afercia
Copy link
Contributor Author

afercia commented Jan 21, 2019

Spent some time on this and couldn't find a good way to count how many addons tabs are active in an abstracted way. Would be nice to check specifically for the addons names. Any suggestions appreciated.

@afercia afercia assigned afercia and unassigned afercia Jan 21, 2019
@afercia afercia mentioned this issue Jan 23, 2019
Merged
1 task
@afercia afercia assigned afercia and unassigned afercia Jan 23, 2019
@IreneStr IreneStr added the queue label Mar 1, 2019
@Dieterrr Dieterrr added code-review and removed queue labels Mar 1, 2019
@Dieterrr Dieterrr self-assigned this Mar 1, 2019
@Dieterrr Dieterrr removed their assignment Mar 1, 2019
@abotteram abotteram self-assigned this Mar 1, 2019
@vraja-pro vraja-pro mentioned this issue Jun 8, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abotteram abotteram

Labels
component: a11y component: metabox
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the add-ons tab non interactive when only one add-on is enabled Yoast/wordpress-seo
5 participants
@omarreiss @afercia @abotteram @Dieterrr @IreneStr