Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Gutenberg styles breaking the snippet editor #13145

Closed
afercia opened this issue Jun 18, 2019 · 0 comments · Fixed by #13146
Closed

Override Gutenberg styles breaking the snippet editor #13145

afercia opened this issue Jun 18, 2019 · 0 comments · Fixed by #13146

Comments

@afercia
Copy link
Contributor

afercia commented Jun 18, 2019

In WordPress/gutenberg#14407 Gutenberg introduced a CSS selector [data-block] used to control margins of the blocks in the editor.

Our Snippet Editor uses Draft.js which in turn uses some data-block attributes in its rendered HTML so the Gutenberg CSS rules are inherited and break the layout of the snippet editor title and description.

See WordPress/gutenberg#15465

A PR has been submitted upstream in the Gutenberg repo. To be 100% sure to avoid the breakage, we should override the Gutenberg CSS rule anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant