Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add polyfill for new assertObjectEquals() #5

Closed
jrfnl opened this issue Oct 26, 2020 · 1 comment · Fixed by #38
Closed

[FR] Add polyfill for new assertObjectEquals() #5

jrfnl opened this issue Oct 26, 2020 · 1 comment · Fixed by #38
Labels
Type: enhancement
Milestone
1.0.0

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Oct 26, 2020 •
edited
Loading

PHPUnit 9.4.0 introduces a new assertion Assert::assertObjectEquals().

Polyfilling this would require copying most of the new code from PHPUnit, which I'm hesistant to do.

Refs:
@jrfnl
Copy link
Collaborator Author

jrfnl commented Jun 12, 2021

Status: I have a working implementation ready, but that implementation is currently limited to PHP >= 7.0 .

I've opened an issue upstream to discuss this further as this limitation is due to how the assertion is implemented in PHPUnit itself.
Ref: sebastianbergmann/phpunit#4707

@jrfnl jrfnl mentioned this issue Jun 17, 2021
Merged
@jrfnl jrfnl added this to the 1.0.0 milestone Jun 17, 2021
@jrfnl jrfnl closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

AssertObjectEquals trait: polyfill the Assert::assertObjectEquals() method Yoast/PHPUnit-Polyfills
1 participant
@jrfnl