-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line exclude regex just for keyword detector #131
Comments
@KevinHock I would like to work on this. |
Awesome @hpandeycodeit, let me know if you need any help 👍 |
@KevinHock Are we looking to change the same files as in this commit 15a6e6a |
@hpandeycodeit We will still change Instead of the Hope this helps 👍 Let me know if you need me to clarify anything |
@KevinHock Thanks for the clarification. I created a PR. Let me know what you think. |
Awesome, thank you @hpandeycodeit 👍 |
Closing as fixed by #132 |
In #127 we added a line exclude for all plugins and reverted 15a6e6a, which was a line exclude regex for just the high-entropy plugins, this was partially due to imagined use-cases of things someone may want to exclude from all plugins e.g. lines whose first non-whitespace character is a
#
, and general cleanliness (DRY).The keyword detector however, is a young plugin with kind of an ambitious goal, and users shouldn't have to add to the
FALSE_POSITIVES
dict things that may be specific to their codebases, and version bumps won't need to happen to trim false positives.This is a good-first-issue, b/c it was done very similarly in 15a6e6a
The text was updated successfully, but these errors were encountered: