Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csc_cython produces images with red and blue channels swapped #922

Closed
totaam opened this issue Jul 18, 2015 · 4 comments
Closed

csc_cython produces images with red and blue channels swapped #922

totaam opened this issue Jul 18, 2015 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 18, 2015

Issue migrated from trac ticket # 922

component: encodings | priority: blocker | resolution: fixed

2015-07-18 17:10:02: totaam created the issue


We don't use it much because we prefer opengl, and even opengl is disabled we usually have swscale available.
The code looks fine (similar to the opencl version).
It could just be that because we return RGBX instead of RGB, we end up in a different code path: paint_rgb32 instead of paint_rgb24..

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2015

2015-07-20 18:05:59: totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2015

2015-07-20 18:05:59: totaam set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2015

2015-07-20 18:05:59: totaam commented


trunk fix in r9983: I'm just not clever enough to figure out how to derive the byte order, so we hardcode it instead (big endian not tested)

Will backport.

@totaam totaam closed this as completed Jul 20, 2015
@totaam
Copy link
Collaborator Author

totaam commented Aug 5, 2015

2015-08-05 03:16:54: antoine commented


This may need further work, as the same swapped colours occur with this fix applied (but with different library versions): #937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant