Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipboard hangs thread #2172

Closed
totaam opened this issue Feb 24, 2019 · 26 comments
Closed

clipboard hangs thread #2172

totaam opened this issue Feb 24, 2019 · 26 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 24, 2019

Issue migrated from trac ticket # 2172

component: clipboard | priority: major | resolution: fixed

2019-02-24 17:28:09: stdedos created the issue


Xpra-Client-x86_64_2.5-[r21454](../commit/5562fb4144e749efb368ee3bf0c242bfb03675be)\xpra_cmd start ssh://user@ip/4  --microphone=off --speaker=off --webcam=no --opengl=no --start-new-commands=yes --start=gnome-terminal

2019-02-23 19:10:49,474 Xpra GTK2 client version 2.5-[r21454](../commit/5562fb4144e749efb368ee3bf0c242bfb03675be) 64-bit
2019-02-23 19:10:49,478  running on Microsoft Windows 10
2019-02-23 19:10:50,554 GStreamer version 1.14.4 for Python 2.7.15 64-bit
2019-02-23 19:10:51,786  keyboard settings: layout=us
2019-02-23 19:10:51,790  desktop size is 1600x900 with 1 screen:
2019-02-23 19:10:51,791   Default (423x238 mm - DPI: 96x96) workarea: 1600x860
2019-02-23 19:10:51,791     DISPLAY1 (309x174 mm - DPI: 131x131)
2019-02-23 19:11:01,494 enabled remote logging
2019-02-23 19:11:01,495 Xpra GTK2 X11 server version 2.5-[r21791](../commit/a052b144e8aca1f688c7376a455c0ce83097ea9b) 64-bit
2019-02-23 19:11:01,496  running on Linux Ubuntu 16.04 xenial
Xpra-Client-x86_64_2.5-[r21454](../commit/5562fb4144e749efb368ee3bf0c242bfb03675be)/lib/xpra/clipboard/clipboard_base.py:937: GtkWarning: ../../../gtk+-2.24.32/gdk/win32/gdkselection-win32.c:423: OpenClipboard failed: Access is denied.

xpra tray reads "1 clipboard requests in progress"

and "everything" hangs. Re-attaching does not helps.

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2019

2019-02-25 05:28:22: antoine changed owner from antoine to stdedos

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2019

2019-02-25 05:28:22: antoine commented


This looks very much like this bug report: Copy to clipboard fails on Win10, 64bit.
The correct fix for this is to move away from GTK's clipboard code: #812.

Until then, python3 / gtk3 builds should work better since we can't use set_with_data there (they've removed the function - yet another reason for not using GTK's clipboard code).
For the python2 / gtk2 builds please try r21867 or later. (beta posted)

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2019

2019-02-25 17:18:39: stdedos commented


Would you please post a Client build?

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2019

2019-02-25 17:31:11: antoine commented


Would you please post a Client build?
That was already done before I posted comment:1.

I have now added a newer python3 build, not that this should make any difference to this particular ticket. The change from r21867 is only used with python2.

@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2019

2019-02-25 19:28:35: stdedos commented


I maybe should've explicitly narrowed it down :-D
an xpra python2 client non-installation build.

Basically, something that ends with .zip, and doesn't require administration rights, installation etc

Or, I don't know; I thought they were still a thing since the discussion on another ticket. They seem to suit just fine to jump between revisions / python versions in the client side

@totaam
Copy link
Collaborator Author

totaam commented Feb 26, 2019

2019-02-26 01:12:18: antoine commented


Basically, something that ends with .zip, and doesn't require administration rights, installation etc
Ah, right. Those ones. I usually skip those for expediency.
Done now.

@totaam
Copy link
Collaborator Author

totaam commented Mar 7, 2019

2019-03-07 12:34:31: antoine commented


Can I close this for 2.5?

@totaam
Copy link
Collaborator Author

totaam commented Mar 7, 2019

2019-03-07 12:39:00: antoine commented


See also #2138

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2019

2019-03-14 12:56:35: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2019

2019-03-14 12:56:35: antoine set resolution to worksforme

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 04:16:13: antoine commented


Proper long term solution: #812

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 09:16:33: stdedos commented


I don't disagree with worksforme and #812 solution.

However, it still doesn't work for me (see attachment)

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 13:54:04: antoine uploaded file client-output.txt (6.2 KiB)

client output

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 13:54:14: antoine uploaded file server-100.log (22.8 KiB)

server log

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 13:54:24: antoine uploaded file cmd_2019-03-19_11-11-38.png (90.2 KiB)

screenshot
cmd_2019-03-19_11-11-38.png

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 14:42:49: antoine changed status from closed to reopened

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 14:42:49: antoine removed resolution (was worksforme)

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 14:42:49: antoine commented


The client log no longer contains the GtkWarning: OpenClipboard failed: Access is denied.

What is the symptom? Does it just hang like that? Can you run it with -d all?
Does it work with the latest python3 builds?
Does it work if you disable clipboard synchronization?

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 15:38:26: stdedos commented


Replying to [comment:11 Antoine Martin]:

The client log no longer contains the GtkWarning: OpenClipboard failed: Access is denied.

What is the symptom? Does it just hang like that? Can you run it with -d all?

Yes it does. I can try -d all in a couple of hours

Does it work with the latest python3 builds?

For the server or the client?

Does it work if you disable clipboard synchronization?

Yes, everything goes down smoothly

@totaam
Copy link
Collaborator Author

totaam commented Mar 19, 2019

2019-03-19 15:40:57: antoine commented


Does it work with the latest python3 builds?
For the server or the client?
Client.

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2019

2019-03-20 12:29:49: stdedos commented


Here are all the diagnostics requested.

tl;dr: I didn't see python2 stucking like that, but no meaningful output is coming with either python version. Missing GUI might be some sort of Heisenbug.

Result is the same: Server seems to be "all good" (session is started, listed etc), but client is stuck on that state)

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2019

2019-03-20 12:30:04: stdedos uploaded file xpra-2172.tar.bz2 (433.5 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Jun 19, 2019

2019-06-19 11:01:40: stdedos commented


I am not sure if you fixed this, but according to #2284 resolution (fixed, worksforme), and that they use "similar commands to invoke", it seems that I don't see that problem anymore.

@totaam
Copy link
Collaborator Author

totaam commented Jun 19, 2019

2019-06-19 11:16:51: antoine changed status from reopened to closed

@totaam
Copy link
Collaborator Author

totaam commented Jun 19, 2019

2019-06-19 11:16:51: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jun 19, 2019

2019-06-19 11:16:51: antoine commented


Feel free to re-open if this re-occurs.

I am pretty confident that the retry approach is correct, if inelegant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant