Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent windows #1570

Closed
totaam opened this issue Jul 10, 2017 · 12 comments
Closed

transparent windows #1570

totaam opened this issue Jul 10, 2017 · 12 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 10, 2017

Issue migrated from trac ticket # 1570

component: core | priority: major | resolution: fixed

2017-07-10 07:08:00: antoine created the issue


Transparency aka "alpha channel" tracker ticket.

Original tickets and important changesets:

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 07:35:41: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 07:35:41: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 07:35:41: antoine commented


Fixes in r16262:

  • skip compositing check with opengl backend on macos (though transparency still doesn't work..)
  • enable transparency by default on macos as this seems to work with both cairo and pixmap backends
  • remove override in pixmap backing, use the superclass default (ie: enabled on macos)
  • add better error logging when initializing / enabling transparency, especially failures

This reverts an earlier changeset: r4934 "transparency does not work on OSX" - as it works with cairo and pixmap, the opengl case may be fixable.
If not, we should disable it in the backend - which will save some bandwidth.

@totaam
Copy link
Collaborator Author

totaam commented Nov 6, 2017

2017-11-06 09:00:03: antoine commented


Hopefully this can be dealt with as part of #1569.

@totaam
Copy link
Collaborator Author

totaam commented Nov 11, 2017

2017-11-11 15:16:05: antoine commented


r17373 enables transparency with GTK3, which works for the cairo backend (with opengl=off).

For opengl, r17375 passes the flag to the glcontext class so it can choose an appropriate visual.
Unfortunately, despite using the DwmEnableBlurBehindWindow (as directed here: [https://stackoverflow.com/a/4055059]), the window remains opaque on win32. See patch attached.

@totaam
Copy link
Collaborator Author

totaam commented Nov 11, 2017

2017-11-11 15:16:30: antoine uploaded file win32-opengl-alpha.patch (2.6 KiB)

try to enable transparency with opengl

@totaam
Copy link
Collaborator Author

totaam commented Nov 12, 2017

2017-11-12 07:17:39: antoine commented


r17385 uses non-opengl rendering if the window requires transparency, will follow up in #1682 for win32.

macos support is blocked by #1575

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2018

2018-03-28 15:14:47: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2018

2018-03-28 15:14:47: antoine commented


r18900 does the same as r17373 on macos: the cairo backend does handle transparency already just fine so let's use it, for opengl: #1794.

@totaam
Copy link
Collaborator Author

totaam commented Sep 21, 2019

2019-09-21 13:16:09: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Sep 21, 2019

2019-09-21 13:16:09: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Sep 21, 2019

2019-09-21 13:16:09: antoine commented


Closing as this is now supported on all platforms, with all the backends, except for win32 + opengl: #1682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant