Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.8: complains about invalid config #1031

Closed
totaam opened this issue Nov 15, 2015 · 13 comments
Closed

0.15.8: complains about invalid config #1031

totaam opened this issue Nov 15, 2015 · 13 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 15, 2015

Issue migrated from trac ticket # 1031

component: core | priority: critical | resolution: fixed

2015-11-15 07:19:49: onlyjob created the issue


Attempt to start Xpra-0.15.8 built from source as xpra start :33 fails with the following in /home/user/.xpra/:33.log:

Parse error on line 104 of section InputClass in file /home/user/.xpra/xpra.conf
        "p<BF>v<88>3V" is not a valid keyword in this section.

It complains on every uncommented line. If I comment a particular line it stops on next uncommented one with the similar error.
This is a regression as 0.15.6 (and earlier versions) did not have such problem.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:26:39: antoine changed owner from antoine to onlyjob

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:26:39: antoine commented


  • Parse error on line.. is not from xpra
  • since you use a specific /home/user/.xpra/xpra.conf, it would be helpful to include it

[[BR]]

This is a regression as 0.15.6 (and earlier versions) did not have such problem.
[[BR]]
I very much doubt that is the case.
My bet is a syntax error on your side.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:32:27: onlyjob changed owner from onlyjob to antoine

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:32:27: onlyjob changed component from android to core

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:32:27: onlyjob commented


No, it is not a syntax error as 0.15.6 works. No, it is not useful to include config because 0.15.8 stops on every un-commented line -- just copy /etc/xpra/xpra.conf as /home/user/.xpra/xpra.conf and make sure that any like keyboard-sync = no or speaker or encoding is set.

Do you think that after all those years of maintaining Xpra I would not recognise a syntax error?

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:39:53: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 07:39:53: antoine commented


Caused by r11013, undoing this change should get you going.
FYI: this is Xorg moaning, not xpra.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 08:06:21: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 08:06:21: antoine changed owner from antoine to onlyjob

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 08:06:21: antoine commented


Should be fixed in r11218 using a directory that should not exist by default named xorg.conf.d (changed from xorgconfdir in r11222), or if it does exist it should be clear that it is for xorg config files only (which is not a bad thing to have in any case, so users can customize their config more easily).

Applied to v0.15.x in 11219, v0.14.x in 11221.

@onlyjob: please confirm and close.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 09:30:34: onlyjob changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 09:30:34: onlyjob set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2015

2015-11-15 09:30:34: onlyjob commented


All good with 11219, thanks.

@totaam totaam closed this as completed Nov 15, 2015
@totaam totaam added the v0.15.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant