Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIE2TargetModel::isLegalMemtileConnection incorrect for many Ctrl, DMA and Trace port connections #1567

Closed
makslevental opened this issue Jun 16, 2024 · 2 comments
Assignees
Labels
aie2 good first issue Good for newcomers

Comments

@makslevental
Copy link
Contributor

isLegalMemtileConnection wrong (reports true when false): src: Ctrl0, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: Ctrl0, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: Ctrl0, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: Ctrl0, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: Ctrl0, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: DMA0, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: DMA0, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: DMA0, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: DMA0, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: DMA0, dst: DMA5
isLegalMemtileConnection wrong (reports true when false): src: DMA1, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: DMA1, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: DMA1, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: DMA1, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: DMA1, dst: DMA5
isLegalMemtileConnection wrong (reports true when false): src: DMA2, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: DMA2, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: DMA2, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: DMA2, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: DMA2, dst: DMA5
isLegalMemtileConnection wrong (reports true when false): src: DMA3, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: DMA3, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: DMA3, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: DMA3, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: DMA3, dst: DMA5
isLegalMemtileConnection wrong (reports true when false): src: DMA4, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: DMA4, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: DMA4, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: DMA4, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: DMA4, dst: DMA5
isLegalMemtileConnection wrong (reports true when false): src: DMA5, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: DMA5, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: DMA5, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: DMA5, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: DMA5, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: Ctrl0
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: DMA0
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: DMA1
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: DMA2
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: DMA3
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: DMA4
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North0
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North1
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North2
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North3
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North4
isLegalMemtileConnection wrong (reports true when false): src: Trace0, dst: North5

See Figure 6-9 in arch spec.

@makslevental makslevental changed the title AIE2TargetModel::isLegalMemtileConnection incorrect for many Ctrl, DMA and Trace connections AIE2TargetModel::isLegalMemtileConnection incorrect for many Ctrl, DMA and Trace port connections Jun 16, 2024
@AndraBisca
Copy link
Collaborator

Is this issue ready to close @Yu-Zhewen ?

@erwei-xilinx
Copy link
Collaborator

Yeah this issue can be closed, as the new AIETargetModel is verified against all cases above, with #1602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aie2 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants