Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Support closing popup that is inside iframe #329

Open
6 tasks
oomelianchuk opened this issue Dec 13, 2024 · 0 comments
Open
6 tasks

Improvement: Support closing popup that is inside iframe #329

oomelianchuk opened this issue Dec 13, 2024 · 0 comments
Labels
codeImplementationNeeded This issue requires a change in the code of Neodymium docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made

Comments

@oomelianchuk
Copy link
Contributor

Quick Description

Sometimes it's required to block popups that appear in iframes. Such popups are currently invisible for our popup blocker because it's required to switch to the iframe to be able to see the element. We should think about supporting this feature

User Story

As a test automation engineer,
I want to block popup that is inside iframe

Functional Requirements

  • iframe selector should be passed along with the selector for close button (so that it's clear that the close button is expected to be found inside iframe
  • popup blocker should be able to block popup that is inside iframe

Research Task

  • iframes with different origin cannot be accessed via JS by default. Please, find the information about browser options to disable CORS for:
  • Chrome ( --disable-web-security; --disable-gpu; --disable-site-isolation-trials; --user-data-dir="~/chrome-dev-disabled-security")
  • Firefox
  • Edge and Safari doesn't support this option

Documentation Requirements

  • Add the new property to the wiki
  • iframes with different origin cannot be accessed via JS by default. Add information about the browser options to disable CORS in wiki

Test Requirements

  • Add Unit tests as far as possible
@oomelianchuk oomelianchuk added docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made codeImplementationNeeded This issue requires a change in the code of Neodymium labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeImplementationNeeded This issue requires a change in the code of Neodymium docsNeeded The documenttion needs to be checked if there are changes needed and if so, adaptions should be made
Projects
None yet
Development

No branches or pull requests

1 participant