Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Support popup selectors with quotes #327

Open
2 tasks
oomelianchuk opened this issue Dec 13, 2024 · 0 comments · May be fixed by #328
Open
2 tasks

Improvement: Support popup selectors with quotes #327

oomelianchuk opened this issue Dec 13, 2024 · 0 comments · May be fixed by #328
Assignees
@oomelianchuk
Labels
codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop

Comments

@oomelianchuk
Copy link
Contributor

Quick Description

Currently popup blocker works well with selectors without quotes (e.g. #myWindow) but if popup need to be selected via e.g. [data-testid='closeIcon'] / [data-testid="closeIcon"] java script exception is thrown in console

User Story

As a test automation engineer,
I want to configure the popup with [data-testid='closeIcon'] / [data-testid="closeIcon"] selector to be automatically blocked

Test Requirements

  • Improve the JavaScriptUtils#injectJavascriptPopupBlocker method
  • Add Unit tests for the data-testid='closeIcon'] / [data-testid="closeIcon"] popup
@oomelianchuk oomelianchuk added the codeImplementationNeeded This issue requires a change in the code of Neodymium label Dec 13, 2024
@oomelianchuk oomelianchuk self-assigned this Dec 13, 2024
oomelianchuk added a commit that referenced this issue Dec 13, 2024
@oomelianchuk
[#327] Improvement: Support popup selectors with quotes
24bad4a
@oomelianchuk oomelianchuk linked a pull request Dec 13, 2024 that will close this issue
[#327] Improvement: Support popup selectors with quotes #328
Open
oomelianchuk added a commit that referenced this issue Dec 16, 2024
@oomelianchuk
[#327] fix popup blocker unit tests
e413a78
oomelianchuk added a commit that referenced this issue Dec 16, 2024
@oomelianchuk
[#327] add line to block popup with quotes
4c33a31
@oomelianchuk oomelianchuk added codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop and removed codeImplementationNeeded This issue requires a change in the code of Neodymium labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oomelianchuk oomelianchuk

Labels
codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop
Projects
None yet
Milestone
No milestone
1 participant
@oomelianchuk