Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a Set of Different Waiting Times #246

Open
wurzelkuchen opened this issue Mar 26, 2024 · 3 comments · May be fixed by #296
Open

Provide a Set of Different Waiting Times #246

wurzelkuchen opened this issue Mar 26, 2024 · 3 comments · May be fixed by #296
Assignees
@wurzelkuchen
Labels
codeChangeRequired During recheck issues for this popped up and needs to be addressed docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop

Comments

@wurzelkuchen
Copy link
Contributor

One thing we add often in customer projects is a set of different waiting times for different use cases (short waiting for hovers to open, medium for simple button clicks, long for complex pages to load...)

Since this is a recurring issue, we should add it to the library.

Requirements:

  • add a useful default set of waiting times (e.g. standard, short, medium, double, long...)
  • make those easily accessible for the user
  • make those configurable
  • add the possibility to add further individual waiting times
@georgkunze georgkunze self-assigned this Sep 25, 2024
@georgkunze georgkunze added docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels Oct 14, 2024
@georgkunze georgkunze linked a pull request Oct 14, 2024 that will close this issue
Added NeoWaitTime #296
Open
@georgkunze
Copy link

Code done. Doku done

@georgkunze
Copy link

Updated code and dokcumentation like discussed yesterday.

@wurzelkuchen wurzelkuchen added codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop and removed codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there labels Oct 23, 2024
@wurzelkuchen wurzelkuchen added codeChangeRequired During recheck issues for this popped up and needs to be addressed and removed codeReadyForMerge The issue was implemented and the branch is ready to be reviewed and merged into develop labels Nov 26, 2024
@wurzelkuchen
Copy link
Contributor Author

After some considerations I like to update the requirements a bit. We can use the code, but I would like to have a different entrance point to the feature:

  • we do not provide a seperate class for this
  • we add the wait methods (like waitStandardWaitTime()) directly to the Neodymium Class so that a user can call Neodymium.waitStandardWaitTime()
  • we add getter Methods to our config class to get each value as a java.time.Duration object (which is needed for all of Selenides should... methods). So that the user can do something like $("something").shouldBe(visible, Neodymium.configuration().standardWaitingDuration())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wurzelkuchen wurzelkuchen

Labels
codeChangeRequired During recheck issues for this popped up and needs to be addressed docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added NeoWaitTime Xceptance/neodymium
2 participants
@wurzelkuchen @georgkunze