From 119a993dbf57a6650b34d28ac46c019ffd5078e0 Mon Sep 17 00:00:00 2001 From: Marcel Pfotenhauer Date: Wed, 17 Apr 2019 11:18:21 +0200 Subject: [PATCH 1/2] #81: update maven dependencies --- pom.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pom.xml b/pom.xml index 1aadf7d7d..df09a6ba0 100644 --- a/pom.xml +++ b/pom.xml @@ -48,7 +48,7 @@ 1.8 2.22.1 2.10.0 - 4.2.3 + 4.3.0 2.11.1 @@ -196,7 +196,7 @@ org.yaml snakeyaml - 1.23 + 1.24 @@ -240,13 +240,13 @@ com.google.guava guava - 27.0.1-jre + 27.1-jre com.codeborne selenide - 5.1.0 + 5.2.2 org.apache.commons @@ -261,12 +261,12 @@ org.apache.commons commons-lang3 - 3.8.1 + 3.9 org.slf4j slf4j-api - 1.7.25 + 1.7.26 From 7f6f81619daba60ab7e3a553db47f53c74b86720 Mon Sep 17 00:00:00 2001 From: Marcel Pfotenhauer Date: Wed, 17 Apr 2019 12:53:07 +0200 Subject: [PATCH 2/2] #78: webdriver tear down without the Scenario as a parameter --- .../com/xceptance/neodymium/util/WebDriverUtils.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/xceptance/neodymium/util/WebDriverUtils.java b/src/main/java/com/xceptance/neodymium/util/WebDriverUtils.java index 716e0c298..54544a971 100644 --- a/src/main/java/com/xceptance/neodymium/util/WebDriverUtils.java +++ b/src/main/java/com/xceptance/neodymium/util/WebDriverUtils.java @@ -75,7 +75,16 @@ public static void setUpWithBrowserTag(Scenario scenario) **/ public static void tearDown(Scenario scenario) { - browserStatement.get().teardown(scenario.isFailed()); + tearDown(scenario.isFailed()); + } + + /** + * @param isFailed + * boolean to pass if the test failed in order to use Neodymium's keepBrowserOpenOnFailure feature + **/ + public static void tearDown(boolean isFailed) + { + browserStatement.get().teardown(isFailed); } static String getFirstMatchingBrowserTag(Scenario scenario)