Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename probability to analytic_probability #24

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

antalszava
Copy link
Contributor

This change follows-up the change in the structure of QubitDevice:
PennyLaneAI/pennylane#573

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   98.70%   99.33%   +0.62%     
==========================================
  Files           6        6              
  Lines         155      151       -4     
==========================================
- Hits          153      150       -3     
+ Misses          2        1       -1     
Impacted Files Coverage Δ
pennylane_cirq/_version.py 100.00% <100.00%> (ø)
pennylane_cirq/cirq_device.py 100.00% <100.00%> (ø)
pennylane_cirq/simulator_device.py 100.00% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddeaea...c11e760. Read the comment docs.

Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@antalszava antalszava requested a review from josh146 April 7, 2020 23:56
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antalszava! I'm curious about the missing 4 lines of coverage - I'm assuming this is because analytic_probability() is not being called in the test suite?

@antalszava
Copy link
Contributor Author

antalszava commented Apr 8, 2020

Thanks! It was the self._state is None case, added a small test for coverage on that! 😊

Other than that implicit calls coming from for example expval in the analytic=True case made up for the other parts in coverage for now.

@antalszava antalszava merged commit de224b5 into master Apr 8, 2020
@antalszava antalszava deleted the analytic_prob branch April 8, 2020 18:55
@antalszava antalszava mentioned this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants