Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support featureXRPFees amendment #526

Closed
ckniffen opened this issue Feb 21, 2023 · 2 comments
Closed

Support featureXRPFees amendment #526

ckniffen opened this issue Feb 21, 2023 · 2 comments

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented Feb 21, 2023 •
edited
Loading

This amendment is part of rippled@1.10.0 and updates the fees to be formatted as Amounts.

XRPLF/rippled#4247

  • autofill logic does NOT need to be updated because it uses fee.
  • Fee property on all transactions remains the same
  • SetFee transactions
    • BaseFeeDrops, ReserveBaseDrops, and ReserveIncrementDrops will be present when the amendment is passed and on new transactions. These will be of the type Amount
    • BaseFee, ReserveBase, ReferenceFeeUnits, ReserveIncrement are valid only historically after the amendment passes
    • No need for validation updates in client libraries as this is a pseudo transaction
    • Types should reflect there will be only one of the two sets of fields
@ckniffen
Copy link
Collaborator Author

XRPLF/rippled#4425

@ckniffen ckniffen mentioned this issue Jun 8, 2023
Closed
@ckniffen
Copy link
Collaborator Author

ckniffen commented Sep 8, 2023

Fixed by #634

@ckniffen ckniffen closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ckniffen