From 6b325d9557833d63d0662b3283346ae1c7e17b0c Mon Sep 17 00:00:00 2001 From: Oleksandr <115580134+oleks-rip@users.noreply.github.com> Date: Mon, 3 Feb 2025 13:38:42 -0500 Subject: [PATCH] Review fixes 3 --- include/xrpl/protocol/Feature.h | 2 +- src/test/app/Credentials_test.cpp | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/xrpl/protocol/Feature.h b/include/xrpl/protocol/Feature.h index c52f312cbfa..1c476df617f 100644 --- a/include/xrpl/protocol/Feature.h +++ b/include/xrpl/protocol/Feature.h @@ -80,7 +80,7 @@ namespace detail { // Feature.cpp. Because it's only used to reserve storage, and determine how // large to make the FeatureBitset, it MAY be larger. It MUST NOT be less than // the actual number of amendments. A LogicError on startup will verify this. -static constexpr std::size_t numFeatures = 87; +static constexpr std::size_t numFeatures = 88; /** Amendments that this server supports and the default voting behavior. Whether they are enabled depends on the Rules defined in the validated diff --git a/src/test/app/Credentials_test.cpp b/src/test/app/Credentials_test.cpp index 04342624a43..48386c2770c 100644 --- a/src/test/app/Credentials_test.cpp +++ b/src/test/app/Credentials_test.cpp @@ -1063,6 +1063,11 @@ struct Credentials_test : public beast::unit_test::suite { using namespace test::jtx; + bool const enabled = features[fixTransactionFlags]; + testcase( + std::string("Test flag, fix ") + + (enabled ? "enabled" : "disabled")); + const char credType[] = "abcde"; Account const issuer{"issuer"}; Account const subject{"subject"}; @@ -1075,11 +1080,6 @@ struct Credentials_test : public beast::unit_test::suite env.close(); { - bool const enabled = features[fixTransactionFlags]; - testcase( - std::string("Test flag, fix ") + - (enabled ? "enabled" : "disabled")); - ter const expected( enabled ? TER(temINVALID_FLAG) : TER(tesSUCCESS)); env(credentials::create(subject, issuer, credType),