New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile errors when building for linux 3.17 and 3.18. #15

Open

mabnhdev opened this issue Oct 31, 2016 · 0 comments

mabnhdev commented Oct 31, 2016

In xpnet/src/xp_netdev_intf.c in xp_nl_msg_if_create(), the following is referencing the incorrect LINUX version.

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
netdev = alloc_netdev(sizeof(struct xp_netdev_priv),
intf_msg->intf_name, xp_netdev_setup);
#else
netdev = alloc_netdev(sizeof(struct xp_netdev_priv), intf_msg->intf_name,
NET_NAME_UNKNOWN, xp_netdev_setup);
#endif

The alloc_netdev() changed to taking 4 args in 3.17.0.

I suggest changing the code to...

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,17,0)
netdev = alloc_netdev(sizeof(struct xp_netdev_priv),
intf_msg->intf_name, xp_netdev_setup);
#else
netdev = alloc_netdev(sizeof(struct xp_netdev_priv), intf_msg->intf_name,
NET_NAME_UNKNOWN, xp_netdev_setup);
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment