Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignatureReference inclusive_ns_prefixes not being copied #231

Closed
mtheisen-solea opened this issue Aug 1, 2023 · 1 comment
Closed

SignatureReference inclusive_ns_prefixes not being copied #231

mtheisen-solea opened this issue Aug 1, 2023 · 1 comment

Comments

@mtheisen-solea
Copy link

mtheisen-solea commented Aug 1, 2023

According to the documentation:
To specify this value separately for reference canonicalizaition, pass a list of one or more [SignatureReference](https://xml-security.github.io/signxml/#signxml.SignatureReference) objects as the reference_uri keyword argument, and set the inclusive_ns_prefixes attribute on those objects.

This does not seem to be working.

Changing the following line seems to fix this.

new_references.append(SignatureReference(URI=uri, c14n_method=reference.c14n_method))

needs to be changed to
new_references.append(SignatureReference(URI=uri, c14n_method=reference.c14n_method, inclusive_ns_prefixes=reference.inclusive_ns_prefixes))

@kislyuk kislyuk closed this as completed in a88eebb Aug 6, 2023
@kislyuk
Copy link
Member

kislyuk commented Aug 6, 2023

Thank you for finding and reporting this issue, I really appreciate it. Fixed in v3.2.1, please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants