Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrax ommits veto_regions #230

Closed
JoranAngevaare opened this issue Oct 7, 2020 · 1 comment
Closed

Bootstrax ommits veto_regions #230

JoranAngevaare opened this issue Oct 7, 2020 · 1 comment
Assignees
@JoranAngevaare

Comments

@JoranAngevaare
Copy link
Contributor

Currently bootstrax doesn't compute the veto_regions available since #207.

There are two ways to do this:

  • Add it in the same way we did for the He Plugins and the Nv
  • Let bootstrax create a new plugin that takes all of the endpoint plugins (e.g. PeaksHe + PeaksNv + event_info_double) and aggregates that in a plugins with save_when.NEVER. This will simplify strax and a single st.make would be needed.
@JoranAngevaare
Copy link
Contributor Author

At the moment we went for option 1 https://github.com/XENONnT/daqnt/pull/1 (i.e. the easy way)

@JoranAngevaare JoranAngevaare self-assigned this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoranAngevaare JoranAngevaare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoranAngevaare