Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CI to trigger build on PR submission #97

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

wj23027
Copy link
Contributor

@wj23027 wj23027 commented Jun 6, 2023

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

add CI to trigger build on PR submission

Checklist

Others

@tyn1998
Copy link
Member

tyn1998 commented Jun 6, 2023

@wj23027 优秀~!可不可以故意push一个会导致build失败的commit上来测试CI是否会因此失败,然后再push一个revert commit撤销这个用于测试目的的更改?

使用git revert <commit_hash>来revert某个commit的修改。

Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,赞!

@wj23027
Copy link
Contributor Author

wj23027 commented Jun 6, 2023

可不可以故意push一个会导致build失败的commit上来测试CI是否会因此失败,然后再push一个revert commit撤销这个用于测试目的的更改?

使用git revert <commit_hash>来revert某个commit的修改。

已经测试过啦,没有问题~

@tyn1998 tyn1998 merged commit a00d57d into X-lab2017:main Jun 6, 2023
@tyn1998 tyn1998 mentioned this pull request Jun 7, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] 代码质量提升
2 participants