Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing merge #55

Closed
Erhannis opened this issue Jul 16, 2019 · 5 comments
Closed

Missing merge #55

Erhannis opened this issue Jul 16, 2019 · 5 comments
Assignees
Labels

Comments

@Erhannis
Copy link
Contributor

I noticed that you merged in my pull request a few weeks ago - but the merge isn't there anymore. Confirmation of the merge happening: 51e21e1
But it doesn't show up in the commit list: https://github.com/WrathChaos/StompClientLib/commits/master

Was that on purpose, or did a glitch/accident happen?

@WrathChaos
Copy link
Owner

WrathChaos commented Jul 17, 2019

Hmmm, I merged it and tested it. I guess it is just a bug. I know this is annoying but can you re-open the PR again? I'm going to upgrade the library with a new publish.

@Erhannis
Copy link
Contributor Author

Did you force push from a computer that didn't have the merge, perhaps? That might have done it. Anyway, sure - I've also added a fix to allow headers to store data that contains ':'s. I'll include that, unless you object, in which case I can try to make a pull request from the commit before it.

@WrathChaos
Copy link
Owner

Thank you so much for your contribution @Erhannis
I accepted your PR and I'm going to publish a new release ASAP.

@WrathChaos
Copy link
Owner

Release 1.3.3

Screenshot 2019-07-18 at 12 29 41

Thank you @Erhannis

@Erhannis
Copy link
Contributor Author

Sure thing; thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants