Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify when plugin update #1127

Closed
Eligioo opened this issue Nov 22, 2016 · 4 comments
Closed

Notify when plugin update #1127

Eligioo opened this issue Nov 22, 2016 · 4 comments

Comments

@Eligioo
Copy link

Eligioo commented Nov 22, 2016

Wouldn't it be a nice new feature if it would be able to notify users when there is a new version available of a plugin?
Instead of uninstall and then install the plugin to fetch the latest version, and lose your settings too (not sure if plugin Settings.json will be deleted after removing a plugin, correct me if i'm wrong)

So i suggest a nice feature to wpm would be to be able to update your plugins.
I recently updated my plugin several times and some users had no idea there where running on an older version.

@roose
Copy link
Contributor

roose commented Nov 24, 2016

I think plugin author can itself make the update feature, for example: alfred workflows checks for update and if it available, shows "Update available" in results list.

@Eligioo
Copy link
Author

Eligioo commented Nov 24, 2016

I have already thought about implementing it myself. But in my opinion it's not a good thing to let every plugin developer implement his own way to let an user notice that there is an update of his plugin. Instead of one uniform way handled by the package maneger.

@lances101
Copy link
Member

@Eligioo, you are right. Manually updating each plugin could become a painful experience if every plugin developer were to use his own approach. As @roose wrote, a workaround would be to add a check your to Query function that would fetch the newest version number from http://api.getwox.com/plugin/{id} and if that version is newer display a result that would change the query to wpm install {plugin_name}. But it is a hack, not a solution.

Once WPM's backend rework gets done, I would take a look at Wox's package manager plugin for the update features. They are not codependent, so if you have the time to implement the client part - we would be happy to see a pull request for it.

If you need a point of reference, here is my view for the basic update functionality:

  • Wox should notify the user about available updates for plugins.
  • The user should be able to disable those notifications. Either for all or on a plugin by plugin basis.
  • Updating would be done via a 'wpm update' command that would return a list of available updates. From there the user can either choose a specific plugin to update or update all of them.

Once the basic functionality is there it could be extended with stuff like ignoring specific plugins for updates, auto-updates, etc. But I wouldn't prioritize on those right now.

@Eligioo
Copy link
Author

Eligioo commented Nov 25, 2016

@lances101 I'm willing to try to implement point 3 of your view for the basic update functionality. I like to be more involved with this project due the fact I use Wox as workflow.

I've already looked a little how the plugin manager is doing the install part of the plugins. Of course you could use small components for the update part.

The way of doing the update, how I think about it, is by sending the list of API.GetAllPlugins to a new website API endpoint wich returns a result of only the plugins that have a newer version. Wich you can than processed as a Query result.

@Eligioo Eligioo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants