Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTNI-131 ⁃ Testing Suite and Continuous Integration Pipeline for WorldBrain #102

Closed
13 tasks
reficul31 opened this issue Sep 14, 2017 · 2 comments
Closed
13 tasks

Comments

@reficul31
Copy link
Contributor

reficul31 commented Sep 14, 2017

Modules To Be Tested(not in order)

  • Activity Logger
  • Blacklist
  • Common UI(single snapshot test)
  • Imports
  • Local Page
  • Options
  • Overview
  • Page Analysis
  • Page Storage
  • Popup
  • Scheduled Task
  • Search
  • Util

Testing issue at Webmemex for reference.

Since I see the project is already setup to run with jest, I am assuming that is the selected test suite for this project.

@reficul31
Copy link
Contributor Author

reficul31 commented Sep 14, 2017

How should the testing suite be setup?

  • Should we have all the tests beside the modules?(eg sr/activity-logger/index.test.js)
  • Should we create a separate test folder containing all the tests?(eg tests/activity_logger/index.test.js)

I think we should go the first way as it has been setup at webmemex. This would allow us to easily manage the tests and move them around. It would also allow us to have an implementation of the test just beside the module which would allow us to make change to the tests easier.
Not to mention the work it would go to manage the same folder structure in two places(src as well as tests).

@poltak @oliversauter Any opinions?

@poltak
Copy link
Member

poltak commented Sep 14, 2017

Should we have all the tests beside the modules?(eg sr/activity-logger/index.test.js)

100% in favour of this option. No reason to create a new mirror dir tree.

@blackforestboi blackforestboi changed the title Testing Suite and Continuous Integration Pipeline for WorldBrain MTNI-131 ⁃ Testing Suite and Continuous Integration Pipeline for WorldBrain Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants