Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the color for selected text #375

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Update the color for selected text #375

wants to merge 1 commit into from

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented May 10, 2022

Fixes #372. This switches the text selection color from coral red to light blue. It also forces the text color to be black when highlighted (against the light blue), since otherwise white text became unreadable.

Screenshots

@ryelle ryelle requested a review from beafialho May 10, 2022 17:23
@ryelle ryelle self-assigned this May 10, 2022
@beafialho
Copy link
Collaborator

Thanks @ryelle! I should have clarified what I meant.

For all the coloured backgrounds my idea was to apply either the light blue or white but with opacity. I've included all examples I could think of here. The top row uses #EFF2FF and the bottom row uses #FFFFFF

Let me know if that makes sense.

Captura de ecrã 2022-05-11, às 09 58 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beafialho beafialho Awaiting requested review from beafialho

Assignees

@ryelle ryelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight color for text doesn't match the color palette
2 participants
@ryelle @beafialho