Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SotW test and visual polish People of WordPress footer block #102

Closed
3 tasks
Tracked by #83
tellyworth opened this issue Dec 2, 2021 · 2 comments · Fixed by #108
Closed
3 tasks
Tracked by #83

SotW test and visual polish People of WordPress footer block #102

tellyworth opened this issue Dec 2, 2021 · 2 comments · Fixed by #108
Assignees
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@tellyworth
Copy link
Contributor

tellyworth commented Dec 2, 2021

The People of WordPress footer block on the news homepage needs testing and improvements for the SotW demo. Here's a recent screenshot from the test site:
Screen Shot 2021-12-02 at 4 14 57 pm

There are some visual differences from the figma design. We need someone to:

  • Test the People of WP footer block
  • Open issues in the SotW milestone for anything that must be fixed in time for the demo
  • Discuss here, propose solutions, and open PRs if possible
@tellyworth tellyworth mentioned this issue Dec 2, 2021
20 tasks
@tellyworth tellyworth added this to the State of the Word preview milestone Dec 2, 2021
@tellyworth tellyworth added Good First Issue Good for newcomers Help Wanted Extra attention is needed labels Dec 2, 2021
@ryelle
Copy link
Contributor

ryelle commented Dec 2, 2021

I was playing with this in Inspector, and adding width: 100% !important to the .wp-block-post-featured-image here gives an interesting effect (the important is needed to override an inline width).

Screen Shot 2021-12-02 at 5 00 11 PM

Screen Shot 2021-12-02 at 5 00 50 PM

Screen Shot 2021-12-02 at 17 01 00

I'd make a PR but I don't have a working dev env at the moment 😅

@scruffian
Copy link
Collaborator

This looks like a duplicate of #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants