Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn is using the non-localized global header and footer #668

Open
timse201 opened this issue Nov 15, 2024 · 8 comments
Open

Learn is using the non-localized global header and footer #668

timse201 opened this issue Nov 15, 2024 · 8 comments

Comments

@timse201
Copy link

The links on global header menu are not localized, resulting in a poor user experience. Also the WordPress logo leads to the English site.

@ryelle
Copy link
Contributor

ryelle commented Nov 15, 2024

@timse201 Can you link to the site you're seeing this issue on? As on #667, I can't reproduce this. If I'm on a de.w.org site, for example https://de.wordpress.org/support/forum/installation/, the logo does link back to https://de.wordpress.org/.

@timse201
Copy link
Author

Thanks for reply.
I see these links on https://learn.wordpress.org/?locale=de_DE

@ryelle
Copy link
Contributor

ryelle commented Nov 15, 2024

Oh I see. Yes, it looks like that site is not using the correct header or footer. There are separate header & footer for the translated sites, and this is using the main English one instead.

The correct header on https://de.wordpress.org/support/forum/installation/

Image

The incorrect header on https://learn.wordpress.org/?locale=de_DE

Image

I'm going to close the other issue, since the root issue is the same for both header and footer.

@ryelle ryelle added the i18n label Nov 15, 2024
@ryelle ryelle moved this to 📋 To do in WordPress.org Nov 15, 2024
@ryelle ryelle changed the title global header menu links are not localized Learn is using the non-localized global header and footer Nov 15, 2024
@timse201
Copy link
Author

ok, thanks

@timse201
Copy link
Author

https://github.com/WordPress/learn/blob/trunk/wp-content/themes/pub/wporg-learn-2024/patterns/footer-content.php#L26

The links here (footer pattern for learn) are also not localized. Support forums and e.g. France has a translated documentation site.

@ryelle
Copy link
Contributor

ryelle commented Nov 15, 2024

That's a separate issue, so I've created WordPress/Learn#3027.

@ryelle
Copy link
Contributor

ryelle commented Nov 21, 2024

I looked into this for a short time today. The issue is that the localized Learn site is not a Rosetta site, so all the code that switches out the main vs rosetta menus is not running.

We could try to find a matching Rosetta site and load the relevant header/footer content that way, but not all the locales available to Learn have corresponding Rosetta sites. For example, https://learn.wordpress.org/?locale=de_DE_formal — the German rosetta site is de.w.org, there is no separate site for formal German. Would it be better to fall back to the parent locale or fall back to the main English site? I assume the parent locale, but I don't know if the variations are too different for that.

@timse201
Copy link
Author

A fallback is fine. We link to German (default) sites in WordPress for German formal.
It seems like PT AO90 falls back to default, too.
https://wordpress.org/plugins/pt-ao90/

Formal just uses another form of address. To keep things simple. You can be translated as du and Sie. We use "du" when we know the person - like a friend or family member. We use "Sie" when we want to be polite to a person we don't know. Therefore, we don't provide meta or rosetta sites.

@tobifjellner can you please lend us an ear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To do
Development

No branches or pull requests

2 participants