Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Breadcrumbs should collapse on mobile #325

Closed
ryelle opened this issue Jan 18, 2023 · 4 comments · Fixed by #437 or #439
Closed

Site Breadcrumbs should collapse on mobile #325

ryelle opened this issue Jan 18, 2023 · 4 comments · Fixed by #437 or #439
Assignees
Labels
[Block] Site Breadcrumbs Redesign Related to the wordpress.org redesign project
Milestone

Comments

@ryelle
Copy link
Contributor

ryelle commented Jan 18, 2023

We've solved the breadcrumbs wrapping on mobile in a few sites so far, WordPress/wporg-developer#166, WordPress/wporg-documentation-2022#19, and now WordPress/wporg-showcase-2022#96.

Let's DRY this up and set some better defaults for the block's CSS.

@ryelle
Copy link
Contributor Author

ryelle commented Jan 30, 2023

Came across this nesting while testing something else. We shouldn't assume any fixed number of nested items or that we can hide items at specific breakpoints, because it might need to start wrapping at 1550px wide 😱

Screenshot 2023-01-30 at 3 35 32 PM

For reference, on the current developer site, this wraps:
Screenshot 2023-01-30 at 3 36 21 PM

@StevenDufresne StevenDufresne self-assigned this Feb 24, 2023
@adamwoodnz adamwoodnz added the Redesign Related to the wordpress.org redesign project label Jul 19, 2023
@adamwoodnz
Copy link
Contributor

adamwoodnz commented Jul 23, 2023

Just noting a new community plugin in this space https://gutenbergtimes.com/introducing-the-breadcrumbs-wordpress-block-plugin/

@StevenDufresne
Copy link
Contributor

Since the breadcrumbs will be pulled into the content area and no longer compete with a variable length menu on the right, I don't think this is needed anymore, at least not in the way this ticket was imagining.

@adamwoodnz
Copy link
Contributor

Temporarily reverted #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Breadcrumbs Redesign Related to the wordpress.org redesign project
Projects
None yet
3 participants