Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content is not centered when browser doesn't support CSS4 selectors. #78

Closed
StevenDufresne opened this issue Aug 14, 2022 · 2 comments · Fixed by #111
Closed

Content is not centered when browser doesn't support CSS4 selectors. #78

StevenDufresne opened this issue Aug 14, 2022 · 2 comments · Fixed by #111
Assignees
@iandunn
Labels
Browser Support [Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working

Comments

@StevenDufresne
Copy link
Contributor

Describe the bug
Similar to issue we saw with the navigation, the group block also uses :where and :not.

For Example:
When this is missing, the content is not centered.

.wp-block-group.wp-container-46 > :where(:not(.alignleft):not(.alignright):not(.alignfull))

Example

OS: Catalina
Safari: 13.1

Screen Shot 2022-08-14 at 7 32 54 PM
@dd32 dd32 added [Type] Bug Something isn't working [Component] Theme Templates, patterns, CSS labels Aug 15, 2022
@ryelle ryelle moved this to 🛑 Pending discussion in WordPress.org Aug 15, 2022
@iandunn
Copy link
Member

iandunn commented Aug 30, 2022

reference for the previous time this happened

@iandunn iandunn mentioned this issue Aug 30, 2022
Open
@iandunn
Copy link
Member

iandunn commented Aug 30, 2022

I opened an upstream issue for this, to fix the root cause. In the mean time I'll add a workaround.

@iandunn iandunn self-assigned this Aug 30, 2022
@ryelle ryelle moved this from 🛑 Pending discussion to 🏗 In progress in WordPress.org Aug 30, 2022
@iandunn iandunn mentioned this issue Aug 31, 2022
Merged
@ryelle ryelle moved this from 🏗 In progress to ✅ Done in WordPress.org Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iandunn iandunn

Labels
Browser Support [Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working
Projects
WordPress.org
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme: Add workaround for unsupported CSS4 selectors WordPress/wporg-main-2022
4 participants
@iandunn @ryelle @dd32 @StevenDufresne