Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing dependency from modal on plugin page should refresh plugins list #20

Open
mrwweb opened this issue Oct 19, 2022 · 2 comments

Comments

@mrwweb
Copy link

mrwweb commented Oct 19, 2022

Instructions

  1. Install a plugin with a dependency
  2. On Plugins > Installed Plugins, click the link of a dependent plugin in the "Requires: {Plugin}" list
  3. Click "Install Now" in the modal to install the plugin

Actual Outcome

The dependent plugin is installed but the plugin is not listed in the list of plugins until the page is refreshed

Expected Outcome

The dependent plugin is listed in the list of plugins and the plugin with dependencies has its options updated to reflect the installed dependency

@afragen
Copy link
Member

afragen commented Oct 19, 2022

Thanks for testing.

Unfortunately that is the expected outcome. The modal is an iframe and the page doesn't refresh automatically. This is all current core function and not specific to this plugin. The modal is the same for any View details modal that you would fine anywhere.

You should try installing the dependencies from the Dependencies tab in the Install Plugins page.

@mrwweb
Copy link
Author

mrwweb commented Oct 19, 2022

You should try installing the dependencies from the Dependencies tab in the Install Plugins page.

I tried that too and it worked fine.

This mostly feels like a bug because of some of the other ways that the messaging and display don't always give a clear forward path for acting on a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants