Add aspect ratio to images within patterns

[richtabor]

We should assign an aspect ratio to image blocks within patterns, so that when replaced the design's original layout is kept intact.

Example:

[colorful-tones]

This could likely overlap with #44

[richtabor]

This is within the patterns themselves; not the images. I'm fine with whatever aspect ratio they're exported with for the most part — I don't see us needing to change those further, unless we're going to consolidate image a bit more.

[colorful-tones]

This is within the patterns themselves

Yep

we're going to consolidate image a bit more.

Yes, this was what I was hinting towards.

[MaggieCabrera]

Is there any pattern that still needs this?

[richtabor]

I think just these two:

• hero — https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/hero.php#L40
• project-description — https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/project-description.php#L33

[MaggieCabrera]

I'm not sure about the hero one. It's on the home page, and on install, if the user doesn't change it, it will look kind of bad

[richtabor]

I'm not sure about the hero one. It's on the home page, and on install, if the user doesn't change it, it will look kind of bad

I'm not following the relevance?

But anyhow, Gutenberg does not support wide/full images with aspect ratio—yet WordPress/gutenberg#53652.

[MaggieCabrera]

I'm not sure about the hero one. It's on the home page, and on install, if the user doesn't change it, it will look kind of bad

I'm not following the relevance?

But anyhow, Gutenberg does not support wide/full images with aspect ratio—yet WordPress/gutenberg#53652.

Sorry! my brain wasn't working this morning and I was thinking this issue was about replacing images with placeholders... Please ignore my comment

[MaggieCabrera]

I think just these two:

* [ ]  hero — https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/hero.php#L40

* [ ]  project-description — https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/project-description.php#L33

none of those work with the aspect ratios that we have in the editor, so I didn't want to make a custom one. I'm closing this one unless we think we should do so