Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verse Block: Migrate styles to theme.json #100

Closed
scruffian opened this issue Nov 27, 2020 · 6 comments
Closed

Verse Block: Migrate styles to theme.json #100

scruffian opened this issue Nov 27, 2020 · 6 comments
Assignees

Comments

@scruffian
Copy link
Collaborator

scruffian commented Nov 27, 2020

The editor styles are:

pre.wp-block-verse {
	padding: 0;
	color: currentColor;
}

The frontend styles are:

.wp-block-verse {
	font-family: var(--entry-content--font-family);
}

The font family will be handled by this PR: WordPress/gutenberg#27332
The padding is being set by the block. I think we should move this to Global Styles, but its tricky because we need to set a default. I added this PR to track it: WordPress/gutenberg#27338
The color seems unnecessary

@scruffian scruffian self-assigned this Nov 27, 2020
@scruffian
Copy link
Collaborator Author

These issues are now closed.

@scruffian
Copy link
Collaborator Author

Reopening this, there were some issues with the implementation

@scruffian scruffian reopened this Dec 9, 2020
@ooker777
Copy link

ooker777 commented May 7, 2021

hi, any update on this? Why does the class has no formatting anymore?

@carolinan
Copy link
Collaborator

@ooker777 I don't believe TT1 Blocks had styles for verse block. Are you thinking of Twenty Twenty-One? Twenty Twenty-One is not supported in this GitHub repository.

@carolinan
Copy link
Collaborator

I don't believe there is anything left to fix here? If there is, then the issue can be reopened.

@ooker777
Copy link

Yes, I'm thinking about Twenty Twenty-One. I'm sorry for posting in the wrong repository. It's just in the top of Google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants